Re: [PATCH v2] PM / suspend: replacing printk

[Richard Weinberger]

Am 27.10.2015 um 20:32 schrieb Saurabh Sengar:
> it fixes the checkpatch.pl <http://checkpatch.pl> warnings

Don't get me wrong, but checkpatch.pl is only a script which makes suggestions.
Especially as these are only warnings and not errors.

IMHO the code is perfectly fine as is.

Thanks,
//richard

> On Oct 28, 2015 12:56 AM, "Richard Weinberger" <richard.weinberger@xxxxxxxxx <mailto:richard.weinberger@xxxxxxxxx>> wrote:
>>
>> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar <saurabh.truth@xxxxxxxxx <mailto:saurabh.truth@xxxxxxxxx>> wrote:
>> > replacing prink(s) with appropriate pr_info and pr_err
>> >
>> > Signed-off-by: Saurabh Sengar <saurabh.truth@xxxxxxxxx <mailto:saurabh.truth@xxxxxxxxx>>
>> > ---
>> >  kernel/power/suspend.c | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> In which way does this patch improve the existing code?
>> You describe what it does but not which problem it solves and
>> why this patch is necessary.
>>
>> --
>> Thanks,
>> //richard
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/