Re: [PATCH] IB/sa: replace GFP_KERNEL with GFP_ATOMIC

From: Jason Gunthorpe
Date: Tue Oct 27 2015 - 16:00:26 EST


On Tue, Oct 27, 2015 at 06:56:50PM +0000, Wan, Kaike wrote:

> > I do wonder if it is a good idea to call ib_nl_send_msg with a spinlock held
> > though.. Would be nice to see that go away.
>
> We have to hold the lock to protect against a race condition that a
> quick response will try to free the request from the
> ib_nl_request_list before we even put it on the list.

Put is on the list first? Use a kref? Doesn't look like a big deal to
clean this up.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/