Re: [PATCH 1/3] virtio_net: Stop doing DMA from the stack

From: Andy Lutomirski
Date: Tue Oct 27 2015 - 22:17:31 EST


On Tue, Oct 27, 2015 at 7:07 PM, Joerg Roedel <jroedel@xxxxxxx> wrote:
> On Tue, Oct 27, 2015 at 06:17:08PM -0700, Andy Lutomirski wrote:
>> From: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
>>
>> Once virtio starts using the DMA API, we won't be able to safely DMA
>> from the stack. virtio-net does a couple of config DMA requests
>> from small stack buffers -- switch to using dynamically-allocated
>> memory.
>>
>> This should have no effect on any performance-critical code paths.
>>
>> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
>> ---
>> drivers/net/virtio_net.c | 53 ++++++++++++++++++++++++++++++++----------------
>> 1 file changed, 36 insertions(+), 17 deletions(-)
>
> Reviewed-by: Joerg Roedel <jroedel@xxxxxxx>

Should I just send this to netdev now for 4.4? We could get this one
out of the way, maybe.

--Andy

--
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/