Re: [PATCH] tracing: Only benchmark the time tracepoints take if tracing is on

From: Steven Rostedt
Date: Tue Oct 27 2015 - 22:28:32 EST


On Tue, 27 Oct 2015 20:12:13 +0800
Chunyan Zhang <zhang.chunyan@xxxxxxxxxx> wrote:

> There's no need to record the time tracepoints take when tracing is off.
> This is because:
> 1) We cannot see these records since ring_buffer record is off at that
> moment.
> 2) If tracing is off and benchmark tracepoint is enabled, the time
> tracepoint takes is fewer than the same situation when tracing is on,
> since the tracepoints need to be wrote into ring_buffer, it would
> take more time. If turn on tracing at this moment, the average and
> standard deviation cannot exactly present the time that tracepoints
> take to write data into ring_buffer.
>

Thanks! I'll add this when I get back from traveling.

-- Steve


> Signed-off-by: Chunyan Zhang <zhang.chunyan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/