Re: [PATCH] leds: bcm6328: Handle default-state of LEDs correctly

From: Jacek Anaszewski
Date: Wed Oct 28 2015 - 06:56:12 EST


Hi Simon,

On 10/26/2015 01:36 PM, Simon Arlott wrote:
On Mon, October 26, 2015 08:45, Jacek Anaszewski wrote:
Hi Simon,

Thanks for the patch. There are conflicts when applying
it to the LED tree:

git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git

Please use it as a code base for your LED development.

This has already been fixed in the devel branch by d19e6b6a0062c86a75365f0715fd079245f6aab9,
although I think bcm6328_led() should adjust its use of the spinlock
to only cover reading the register and call bcm6328_led_set() instead
of copying the code from it.


It is also on the for-next branch. Feel free to submit the patch,
if you see the room for improvement.

--
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/