Re: [PATCH 0/5 v3] Fix NVMe driver support on Power with 32-bit DMA
From: Busch, Keith
Date: Wed Oct 28 2015 - 09:59:32 EST
On Tue, Oct 27, 2015 at 05:54:43PM -0700, David Miller wrote:
> From: "Busch, Keith" <keith.busch@xxxxxxxxx>
> Date: Tue, 27 Oct 2015 22:36:43 +0000
>
> > If you're suggesting to compile-time break architectures that currently
> > work just fine with NVMe, let me stop you right there.
>
> Silently "working" without the architecture maintainer having to explicity
> look at the new interface and make sure his platform is implementing it
> properly is an extremely bad practice.
It won't work if it's wrong. It'll BUG_ON, and I'll be assigned to help
fix it, like what's happened here (on a private bugzilla).
The "new" interface for all the other architectures is the same as the
old one we've been using for the last 5 years.
I welcome x86 maintainer feedback to confirm virtual and DMA addresses
have the same offset at 4k alignment, but I have to insist we don't
break my currently working hardware to force their attention.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/