Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

From: Javier Martinez Canillas
Date: Wed Oct 28 2015 - 20:12:42 EST


Hello Lee,

On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski
<k.kozlowski@xxxxxxxxxxx> wrote:
> On 28.10.2015 23:38, Lee Jones wrote:
>> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote:
>>> They are not maintainers according to your definition of maintainer
>>> that doesn't seem what most people agree with.
>>
>> "most people" so far are 3 people that I assume still want to be
>> Maintainers despite not actually conducting Maintainer duties, but
>> are rather Reviewers. I also have 2 Acks for this patch, so thus far
>> that's 3 that agree and 3 that do not. Unsurprisingly the ones that
>> agree are Maintainers and the ones who are not are (by my definition)
>> Reviewers -- go figure.
>>
>
> I am not sure on which side you put me finally. :)
> If there is a consensus among some more experienced developers that
> maintainer means branch and patches maintaining, then I won't see any
> problem with the patch nor with switching Samsung PMIC entries to review.
>
> In that case, that would be:
> Acked-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
>

Same for me, what I don't want is to have different meanings per
subsystems of what maintainers and reviewers mean since that could
confuse developers posting patches.

But if there is a kernel wide consensus and all subsystems entries are
going to be updated to use the same semantics and list as Reviewer to
people that don't keep git trees, then I'm OK with this patch and you
can add my:

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

> Best regards,
> Krzysztof
>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/