Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs

[Lu, Baolu]

On 10/28/2015 05:27 PM, Oliver Neukum wrote:
> > +static int fill_buffer(struct debug_buffer *buf)
> > >+{
> > >+	int ret;
> > >+
> > >+	if (buf->output_buf)
> > >+		return -EINVAL;
> > >+
> > >+	buf->alloc_size = PAGE_SIZE;
> > >+	buf->output_buf = vmalloc(buf->alloc_size);
> That really makes no sense. If you allocate exactly
> PAGE_SIZE, you should allocate a page.

Yes, I will change it in v2.

> 	Regards
> 		Oliver

Thanks,
Baolu

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/