Re: [PATCH v13 2/5] gennvm: Generic NVM manager

[Jens Axboe]

On 10/29/2015 08:41 AM, Dongsheng Yang wrote:
> On 10/28/2015 08:30 AM, Matias BjÃrling wrote:
> > The implementation for Open-Channel SSDs is divided into media
> [...]
> > +        lun->reserved_blocks = 2; /* for GC only */
> > +        lun->vlun.id = i;
> > +        lun->vlun.lun_id = i % dev->luns_per_chnl;
> > +        lun->vlun.chnl_id = i / dev->luns_per_chnl;
>
> Please use do_div(). % would be not supported in some platforms, as
> the kbuild pointed in V12.

Neither of those are 64-bit variables, which is where you end up with 
the problem on 32-bit archs.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/