Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

From: Lee Jones
Date: Thu Oct 29 2015 - 04:08:52 EST


On Thu, 29 Oct 2015, Alim Akhtar wrote:

> From: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
>
> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains
> 27 LDO and 10 Buck regulators and allows programming these regulators via a
> I2C interface. This patch adds initial support for LDO/Buck regulators of
> S2MPS15 PMIC.
>
> Signed-off-by: Thomas Abraham <thomas.ab@xxxxxxxxxxx>
> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
> drivers/regulator/Kconfig | 4 +-
> drivers/regulator/s2mps11.c | 135 ++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 136 insertions(+), 3 deletions(-)

[...]

> @@ -1070,6 +1202,7 @@ static const struct platform_device_id s2mps11_pmic_id[] = {
> { "s2mps11-pmic", S2MPS11X},
> { "s2mps13-pmic", S2MPS13X},
> { "s2mps14-pmic", S2MPS14X},
> + { "s2mps15-regulator", S2MPS15X},
> { "s2mpu02-pmic", S2MPU02},
> { },
> };

Are you going to s/pmic/regulator/ for the existing devices too?

[...]

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/