Re: [PATCH] audit: removing unused variable

From: Paul Moore
Date: Thu Oct 29 2015 - 10:06:20 EST


On Wed, Oct 28, 2015 at 6:12 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote:
>> On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote:
>> > variavle rc in not required as it is just used for unchanged for return,
>> > and return is always 0 in the function.
> []
>> Thanks, applied with some spelling corrections to the description.
>
> As the return value is never actually tested,
> it seems better to make it a void function,

Agreed, I did just that yesterday.

* https://www.redhat.com/archives/linux-audit/2015-October/msg00125.html

--
paul moore
www.paul-moore.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/