Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

[Pankaj Dubey]

Hi Pavel,

On 29 October 2015 at 18:12, Pavel Fedin <p.fedin@xxxxxxxxxxx> wrote:
> This machine uses own SoC device tree file, add missing part.
>
> Signed-off-by: Pavel Fedin <p.fedin@xxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/exynos5410.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi
> index 4603356..da6a8fa0e 100644
> --- a/arch/arm/boot/dts/exynos5410.dtsi
> +++ b/arch/arm/boot/dts/exynos5410.dtsi
> @@ -101,6 +101,15 @@
>                         reg = <0x10000000 0x100>;
>                 };
>
> +               sromc: sromc@12250000 {
> +                       #address-cells = <1>;
> +                       #size-cells = <1>;
> +                       ranges;
> +

We do not need to specify these three properties as they are already
present in parent node "soc".

> +                       compatible = "samsung,exynos-srom";
> +                       reg = <0x12250000 0x14>;
> +               };
> +
>                 pmu_system_controller: system-controller@10040000 {
>                         compatible = "samsung,exynos5410-pmu", "syscon";
>                         reg = <0x10040000 0x5000>;
> @@ -133,6 +142,12 @@
>                                                 <10 &gic 0 130 0>,
>                                                 <11 &gic 0 131 0>;
>                         };
> +
> +                       arch_timer {
> +                               compatible = "arm,armv7-timer";
> +                               clock-frequency = <24000000>;
> +                       };
> +

This change should not be part of this patch.

Thanks,
Pankaj Dubey

>                 };
>
>                 sysram@02020000 {
> --
> 2.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/