Re: [PATCH v3] Input: tsc2005 - Add support for tsc2004

From: Mark Brown
Date: Thu Oct 29 2015 - 20:39:30 EST


On Thu, Oct 29, 2015 at 03:23:31PM -0700, Dmitry Torokhov wrote:

> However, you have regmap in the driver core already. Mark, is it
> possible to have regmap API also allow doing raw underlying protocol
> transfer so that consumers could issue command requests without needing
> to know if they need to do it over i2c or spi or whatever. Or we need a
> notion of command registers in regmap...

I don't think it's a good idea to break the encapsulation of the regmap
and export the raw I/O functionality directly, there seem to be more bad
ways of using that than good. The driver must at some point know what
bus it is dealing with and be able to manage this itself.

I don't know what "command registers" are.

Attachment: signature.asc
Description: PGP signature