Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

[Alim Akhtar]

Hi Krzysztof,

On 10/30/2015 02:08 PM, Krzysztof Kozlowski wrote:
> On 30.10.2015 15:25, Alim Akhtar wrote:
> > RTC found in s2mps15 is almost same as one found on s2mps13
> > with few differences in RTC_UPDATE register fields, like:
> > 1> Bit[4] and Bit[1] are reversed
> >     - On s2mps13
> >            WUDR -> bit[4], AUDR -> bit[1]
> >     - On s2mps15
> > 	  WUDR -> bit[1], AUDR -> bit[4]
> > 2> In case of s2mps13, for alarm register, need to set both
> >     WDUR and ADUR high, whereas for s2mps15 only set AUDR to high.
> > 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used
> >     at the same time.
> >
> > This patch add required changes to enable s2mps15 rtc timer.
> >
> > Cc: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> > ---
> >   drivers/rtc/rtc-s5m.c           |   37 +++++++++++++++++++++++++++++++++----
> >   include/linux/mfd/samsung/rtc.h |    2 ++
> >   2 files changed, 35 insertions(+), 4 deletions(-)
>
> The usage of rtc_udr_mask is now a little bit messy and not-consistent
> but this can be fixed in separate patch.
>
> Current approach is the simplest way to add S2MPS15 and looks correct:
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
Thanks!

> Best regards,
> Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/