RE: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by fwnode_handle

[Jake Oshins]

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx]
> Sent: Thursday, October 29, 2015 5:28 PM
> To: Jake Oshins <jakeo@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; Vitaly
> Kuznetsov <vkuznets@xxxxxxxxxx>; tglx@xxxxxxxxxx; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; marc.zyngier@xxxxxxx; Jiang Liu
> <jiang.liu@xxxxxxxxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; linux-
> pci@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by
> fwnode_handle
> 
> On Fri, Oct 30, 2015 at 1:46 AM,  <jakeo@xxxxxxxxxxxxx> wrote:
> > From: Jake Oshins <jakeo@xxxxxxxxxxxxx>
> >
> > This patch adds a second way of finding an IRQ domain associated with
> > a root PCI bus.  After looking to see if one can be found through
> > the OF tree, it attempts to look up the IRQ domain through an
> > fwnode_handle stored in the pci_sysdata struct.
> 
> 
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > +       /*
> > +        * If no IRQ domain was found via the OF tree, try looking it up
> > +        * directly through the fwnode_handle.
> > +        */
> > +       if (!d) {
> > +               if (pci_fwnode(bus)) {
> 
> Isn't it the same to
> if (!d && pci_fwnode(bus))
>  d = ...
> 

Thanks.  I'll make this change and resend.

-- Jake Oshins
N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ0¶ìå