Re: [PATCH v5 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

[Lee Jones]

On Fri, 30 Oct 2015, Linus Walleij wrote:

> On Fri, Oct 30, 2015 at 12:38 AM, Andrew F. Davis <afd@xxxxxx> wrote:
> 
> > This patch adds support for the TPS65912 PMIC GPIOs.
> >
> > TPS65912 has five configurable GPIOs that can be used for several
> > purposes.
> >
> > Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> 
> This looks like a fine driver, can't really see anything wrong with it so:
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> > +#define to_tps65912_gpio(gc) container_of(gc, struct tps65912_gpio, gpio_chip)
> 
> I would rewrite that to static inline however.
> 
> Lee can take this into the MFD tree with my review-tag if he wants.

Please fix this, then resubmit the set with Acks/Reviewed-by's applied.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/