Re: [PATCH v2] arm64: dts: Added syscon-reboot node for FSL's LS2085A SoC

[Arnd Bergmann]

On Friday 30 October 2015 16:34:26 Stuart Yoder wrote:
> My suggestion is to perhaps make that more explicit in the proposed
> device tree node, by making the reg size "4" and naming it
> as per the register name
> 
>        rstcr: rstcr@1E60000 {
>                compatible = "syscon";
>                reg = <0x0 0x1E60000 0x0 0x4>;
>        };
> 
> The intent is really just to expose a single reset register
> and use syscon-reboot until PSCI is available.

I would rather see a more specific compatible string here that describes
the actual name, e.g.

	compatible = "fsl,ls2085a-rstcr", "syscon";

this way we have the option of making it a real driver later on by matching
on the specific string, but using the fallback syscon string otherwise.

BTW, please change the address to lowercase letters in both the node name and
the reg property. I would also change the name to 'syscon' instead of 'rstcr',
making that

	rstcr: syscon@1e60000 {
		...
	};

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/