Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

[Andy Shevchenko]

On Sun, Nov 1, 2015 at 11:59 AM, Ranjith <ranjithece24@xxxxxxxxx> wrote:
> BIT macro is used for defining bit location instead of shifting
> operator -  coding style issue

>  #define APCI1032_CTRL_INT_OR           (0 << 1)

> +#define APCI1032_CTRL_INT_AND          BIT(1)

And now you have two styles at the same time. I wouldn't change the
current definitions.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/