RE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver

From: Noam Camus
Date: Mon Nov 02 2015 - 02:57:53 EST

> From: Daniel Lezcano [mailto:daniel.lezcano@xxxxxxxxxx]
> Sent: Sunday, November 01, 2015 10:44 PM

> Please add an entry in the clocksource's Kconfig.

> eg:

> Are you sure all the headers are needed ?
Thanks, will revise this part.

> Why do you need to disable the interrupt here ?
Thanks, seem like left over from past issue, I will remove.

> May be you can consider using only the 32bits. Sometimes it is faster than using 64bits arithmetic and reading the register three times.

Our device can reach 1000MHz.
That means that the 32-bit half of the counter rolls over every ~4 seconds.
I am not sure optimization is justified.


N‹§²æ¸›yú²X¬¶ÇvØ–)Þ{.nlj·¥Š{±‘êX§¶›¡Ü}©ž²ÆzÚj:+v‰¨¾«‘êZ+€Êzf£¢·hšˆ§~†­†Ûÿû®w¥¢¸?™¨è&¢)ßf”ùy§m…á«a¶Úÿ 0¶ìå