Re: [PATCH RESEND 14/16] hwmon: add TI LMU hardware fault monitoring driver

[Guenter Roeck]

On 11/01/2015 09:24 PM, Milo Kim wrote:
> LM3633 and LM3697 are TI LMU MFD device.
> Those device have hardware monitoring feature which detects opened or
> shorted circuit case.
Sure, but it only makes sense if you provide standard hwmon attributes
which can be interpreted by the "sensors" command. Which is not the case
here. You neither have a standard device type (light is not handled by hwmon),
nor standard attributes, nor do the attributes return standard values.

I think there may be a basic misunderstanding. hwmon is not intended
to monitor a specific chip on the board. Its scope is to monitor the
system (such as temperature, voltages, or current).

In your case, it might be better to attach the attributes to the mfd device.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/