Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

From: Jeff Moyer
Date: Mon Nov 02 2015 - 09:58:37 EST

Jens Axboe <axboe@xxxxxxxxx> writes:

> On 10/30/2015 09:34 AM, Jeff Moyer wrote:
>> From: Vivek Goyal <vgoyal@xxxxxxxxxx>
>> If a block device is hot removed and later last reference to device
>> is put, we try to writeback the dirty inode. But device is gone and
>> that writeback fails.
>> Currently we do a WARN_ON() which does not seem to be the right thing.
>> Convert it to a ratelimited kernel warning.
> Any concerns with putting this into 4.4 and marking it for stable?

No, that sounds fine to me.

> Would be awesome to have a "Fixes:" in here too.

OK. I don't know which commit introduced the problem. Do you want
something like this?


I know some folks don't like mailing list archive links in the commit

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at