Re: [PATCH 04/16] Documentation: dt-bindings: leds: add LM3633 LED binding information

[Kim, Milo]

Hi Rob,

On 11/2/2015 11:53 PM, Rob Herring wrote:
> On Sun, Nov 1, 2015 at 11:01 PM, Milo Kim <milo.kim@xxxxxx> wrote:
> > LM3633 LED device is one of TI LMU device list.
> >
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx>
> > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > Cc: linux-leds@xxxxxxxxxxxxxxx
> > Signed-off-by: Milo Kim <milo.kim@xxxxxx>
> > ---
> >   .../devicetree/bindings/leds/leds-lm3633.txt       | 28 ++++++++++++++++++++++
> >   1 file changed, 28 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3633.txt b/Documentation/devicetree/bindings/leds/leds-lm3633.txt
> > new file mode 100644
> > index 0000000..bb7f213
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/leds-lm3633.txt
> > @@ -0,0 +1,28 @@
> > +TI LMU LM3633 LED device tree bindings
> > +
> > +Required properties:
> > +  - compatible: "ti,lm3633-leds"
> > +
> > +Child nodes:
> > +  Each node matches with LED control bank.
> > +  Please refer to the datasheet [1].
> > +
> > +  Required properties of a child node:
> > +  - lvled1-used, lvled2-used, lvled3-used,
> > +    lvled4-used, lvled5-used, lvled6-used:
> > +    Low voltage LED string configuration. Type is <boolean>.
> > +    Please describe which output LED string is used.
>
> What is "LED string"?

Let me replace these properties with 'led-sources'.

> We have properties for which LED driver/channel of the parent to use
> and "status" can be used to disable child nodes.
>
> > +
> > +  Optional properties of a child node:
> > +  - channel-name: Name string for LED channel identification
> > +                  It is used for creating LED sysfs,
> > +                  /sys/class/leds/<channel-name>/.
> > +                  If this property is empty, then default name is set to
> > +                  "indicator:<id>" by the driver.
>
> I believe "label" already provides this function.

Yep, got it. Thanks!

Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/