Re: net: lockdep warning in ip_mc_msfget (net/ipv4/igmp.c:2400)

From: Marcelo Ricardo Leitner
Date: Tue Nov 03 2015 - 06:21:22 EST


Em 02-11-2015 22:38, Cong Wang escreveu:
On Mon, Nov 2, 2015 at 1:31 PM, Cong Wang <cwang@xxxxxxxxxxxxxxxx> wrote:

Good catch!

This is probably introduced by:

commit baf606d9c9b12517e47e0d1370e8aa9f7323f210
Author: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>
Date: Wed Mar 18 14:50:42 2015 -0300

ipv4,ipv6: grab rtnl before locking the socket

Yes, that commit introduced this inverse order situation by not fixing the get path of it.

I am thinking what is the right way to fix it...

Please try the attached patch.

Thanks!

Patch LGTM, same design and covered all rtnl_lock()s I could find on get path now. Thanks!

Marcelo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/