Re: [RFC] iommu: arm-smmu: correct reference count

[Will Deacon]

On Tue, Nov 03, 2015 at 08:59:17PM +0800, Peng Fan wrote:
> iommu_group_alloc will initialize the reference count for group to 1.
> iommu_group_add_device also increase the group reference count,
> if nothing bad happends. And we need to add iommu_group_put to
> decrease the reference count for group.
> 
> Signed-off-by: Peng Fan <van.freenix@xxxxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> ---
> 
> Not sure whether my understanding is correct or not. I checked rockchip-iommu.c
> exynos-iommu.c and fsl_pamu_domain.c, and they all have iommu_group_put after
> iommu_group_add_device.

Doesn't this pair up with the iommu_group_remove_device in
arm_smmu_remove_device? Are you actually seeing an issue in practice?

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/