Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

From: Jarod Wilson
Date: Tue Nov 03 2015 - 08:57:16 EST

Geert Uytterhoeven wrote:
On Tue, Nov 3, 2015 at 11:03 AM, Nikolay Aleksandrov
<nikolay@xxxxxxxxxxxxxxxxxxx> wrote:
On 11/03/2015 03:55 AM, Jarod Wilson wrote:
+#define for_each_netdev_feature(mask_addr, feature) \
+ int bit; \
+ for_each_set_bit(bit, (unsigned long *)mask_addr, NETDEV_FEATURE_COUNT) \
+ feature = __NETIF_F_BIT(bit);
This is broken, it will not work for more than a single feature.

Indeed it is.

This is used as:

for_each_netdev_feature(&upper_disables, feature) {

which expands to:

int bit;
for_each_set_bit(bit, (unsigned long *)mask_addr, NETDEV_FEATURE_COUNT)
feature = __NETIF_F_BIT(bit);

Note the assignment to "feature" happens outside the {}-delimited block.
And the block is always executed once.

Bah, crap, I was still staring at the code not seeing it, thank you for the detailed cluebat. I'll fix that up right now.

Jarod Wilson

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at