Re: [patch, v2] blk-mq: avoid excessive boot delays with large lun counts

[Jens Axboe]

On 11/03/2015 06:27 AM, Jeff Moyer wrote:
> Ming Lei <tom.leiming@xxxxxxxxx> writes:
>
> > > > The above should be 'else if', otherwise the current queue will be set
> > > > twice.
> > >
> > > I moved the list add below this to avoid that very issue.  See:
> > >
> > > > > +               queue_set_hctx_shared(q, true);
> > > > >          list_add_tail(&q->tag_set_list, &set->tag_list);
> > >             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > >
> > > This seemed the cleanest way to structure the code to avoid the double
> > > walking of the hctx list for the current q.
> >
> > OK, it is correct, then v1 is fine.
> >
> > Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>
>
> Thanks, Ming.  Jens, I'll re-send with the list_is_singular change and
> this one should be ready for merging.

Great, thanks Jeff!

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/