RE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver

[Noam Camus]

From: Vineet Gupta [mailto:Vineet.Gupta1@xxxxxxxxxxxx] 
Sent: Monday, November 02, 2015 1:04 PM

>> +
>> +	upper = ioread32be(upper_p);

>Consider using the _relaxed macros even if your platform doesn't have specific IO barriers.
[Noam Camus] What is the big endian flavor for _relaxed macros.
 
>> +	counter = upper;
>> +	counter <<= 32;
>> +	counter |= lower;

>It is easier to read:

>counter = (upper << 32) | lower;

Thanks I will update

- Noam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/