Re: [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h systems

[Aravind Gopalakrishnan]

On 11/3/2015 1:52 PM, Borislav Petkov wrote:
> On Tue, Nov 03, 2015 at 01:41:53PM -0600, Aravind Gopalakrishnan wrote:
> > cpu_llc_id references should be wrapped under #ifdef CONFIG_SMP.
> >
> > Did that and kernel build worked with the attached config.
> >
> > Will send a V2 with the fix.
> Why aren't you doing all that figuring out what the llc_id is in
> amd_detect_cmp() which is already CONFIG_SMP ifdeffed?
>
> Which is where that code belongs anyway...

Since we needed to modify last level cache IDs, I thought 
init_amd_cacheinfo() might be a logical place to put it.

But you are right, makes sense to move it to amd_detect_cmp().
I'll do that in V2.

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/