Re: [PATCH 10/31] perf test: Enforce LLVM test for BPF test

From: Wangnan (F)
Date: Tue Nov 03 2015 - 20:43:06 EST

On 2015/11/4 2:24, Arnaldo Carvalho de Melo wrote:
Em Thu, Oct 15, 2015 at 07:58:38PM +0800, Wangnan (F) escreveu:
+void test__llvm_prepare(void)
+ p_test_llvm__bpf_result = mmap(NULL, SHARED_BUF_INIT_SIZE,
+ if (!p_test_llvm__bpf_result)
It should check MAP_FAILED instead.

Fixed by this way:
Can you please try refreshing this patchset on top of what is now in

Also why do we need those struct test->{prepare,cleanup} pointers? You
introduced it and then, on the next patch that touches 'perf test' and
uses test__llvm_{prepare,cleanup} you call them directly, which I think
should be enough, i.e. keep them as functions to call from inside
the test called from run_test(), right?

- Arnaldo

This prepare/cleanup functions are introduced because I want BPF
test reuse the result of LLVM test, so it don't need to compile
those BPF scripts twice. This is the reason I use shared
memory. However, now I think compiling twice is acceptable and
can make things simpler.

I'll update this patchset in my next pull request.

Thank you.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at