Re: [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing

[Jiri Olsa]

On Mon, Nov 02, 2015 at 05:50:22PM -0800, Andi Kleen wrote:

SNIP

>  		evsel->attr.type == PERF_TYPE_HW_CACHE &&
>  		evsel->attr.config ==  ( PERF_COUNT_HW_CACHE_L1D |
>  					((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
> -					((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16)) &&
> -			runtime_l1_dcache_stats[ctx][cpu].n != 0) {
> -		print_l1_dcache_misses(out, cpu, evsel, avg);
> +					 ((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16))) {
> +		if (runtime_l1_dcache_stats[ctx][cpu].n != 0)
> +			print_l1_dcache_misses(cpu, evsel, avg, out);
> +		else
> +			print_metric(ctxp, NULL, NULL, "of all L1-dcache hits", 0);

hum, what's the reason for all those else cases
ending up printing nothing?

we have one metric per line anyway right?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/