Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c

From: Peter Zijlstra
Date: Wed Nov 04 2015 - 07:22:03 EST

On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote:
> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote:
> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace.
> >
> > The names in here are so generic that I don't think it's a good idea
> > to expose them to userspace (or even the rest of the kernel). Since
> > there's only one kernel user, it's been moved to that file.
> >
> > Signed-off-by: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> > Reviewed-by: Andrew Waterman <waterman@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> Assuming you want to keep all these patches together in a tree or so.
> Let me know if you want me to take this patch.
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Ah, build-bot finds your change is broken and you didn't grep right. It
is used in more places.

How about moving it to include/linux/hw_breakpoint.h, instead of having
it in the uapi crud?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at