Re: [PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support
From: Mark Brown
Date: Wed Nov 04 2015 - 09:41:40 EST
On Tue, Nov 03, 2015 at 03:36:11PM +0530, Vignesh R wrote:
> + ti_qspi_enable_memory_map(spi);
> + ti_qspi_setup_mmap_read(spi, read_opcode, addr_width,
> + dummy_bytes);
> + memcpy_fromio(buf, qspi->mmap_base + from, len);
> + *retlen = len;
> + ti_qspi_disable_memory_map(spi);
We'll be constantly enabling and disabling memory mapping with this.
I'm not sure that's a meaningful cost given that it doesn't actually
remap anything but rather just switches hardware modes, we can always
optimise it later if it is.
Attachment:
signature.asc
Description: PGP signature