Re: [PATCH 1/8] dt-bindings: consolidate display related bindings

From: Thierry Reding
Date: Wed Nov 04 2015 - 09:47:58 EST

On Thu, Oct 01, 2015 at 05:12:27PM -0500, Rob Herring wrote:
> This is a quite large renaming to consolidate display related bindings
> into a single "display" directory from various scattered locations of
> video, drm, gpu, fb, mipi, and panel. The prior location was somewhat
> based on the Linux driver location, but bindings should be independent
> of that.

Sorry for being so late to comment on this. I hadn't seen the patches
before and noticed only because various bindings that I chanced to look
at had moved in linux-next.

> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt
> similarity index 100%
> rename from Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt
> rename to Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt

That's not quite correct in my opinion. host1x is a top-level module
that is the parent for a number of hardware blocks, only some of which
are display-related. host1x itself has nothing to do with display at
all, except perhaps for providing syncpoints for VBLANK counters. It's
not a GPU either, though the GPU hardware blocks are children (at least
on generations before Tegra124). Other children include hardware blocks
that do video encoding and decoding, so aren't really related to display

I suppose Documentation/devicetree/bindings/bus might be a more adequate
location for the host1x bindings, but then we'd need to split out the
display related pieces, and possibly refer to the host1x document from
them. The gr2d and gr3d could then be kept in the gpu subdirectory.

Also the MIPI block is a calibration block that's used for both DSI and
CSI lanes, so it's used for both video display and capture. I can't
think of a good location for those.

Also I notice that this patch doesn't update the MAINTAINERS entries
pointing at these documents, so maintainers will now no longer get Cc'ed
on patches that modify the bindings. Do you plan on fixing that up your-
self or do you expect maintainers to send patches, possibly after
further cleanup of the bindings?


Attachment: signature.asc
Description: PGP signature