Re: [PATCH v4 4/5] regulator: tps65912: Add regulator driver for the TPS65912 PMIC

From: Andrew F. Davis
Date: Wed Nov 04 2015 - 10:35:49 EST

On 10/22/2015 11:47 AM, Mark Brown wrote:
On Thu, Oct 01, 2015 at 03:37:53PM -0500, Andrew F. Davis wrote:

+static const struct of_device_id tps65912_regulator_of_match_table[] = {
+ { .compatible = "ti,tps65912-regulator", },
+ { /* sentinel */ },
+MODULE_DEVICE_TABLE(of, tps65912_regulator_of_match_table);

Does this IP block exist outside of the tps65912? If not why is it
directly represented in DT? It seems like this is describing how Linux
loads drivers not how the hardware is constructed but DT should describe
the hardware.

Something I just noticed, when I remove this table, module loading stops
working, even with 'MODULE_ALIAS("platform:tps65912-regulator");'. It
looks like when DT is enabled platform_uevent (drivers/base/platform.c:787)
only sends out the OF MODALIAS event then returns, not sending out the
platform event, is this desired behavior? If so then I will need this
table even though I still create the device and match it on platform
name as you suggested.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at