Re: perf related lockdep bug

[Peter Zijlstra]

On Wed, Nov 04, 2015 at 03:20:58PM +0100, Peter Zijlstra wrote:
> On Wed, Nov 04, 2015 at 05:48:38AM -0800, Paul E. McKenney wrote:
> > This problem is caused by the IPI handler interrupting the RCU read-side
> > critical section.  One way to prevent the IPI from doing this is to
> > disable interrupts across the RCU read-side critical section instead
> > of merely disabling preemption.  This is a reasonable approach given
> > that acquiring the scheduler locks is going to disable interrupts
> > in any case.
> > 
> > The (untested) patch below takes this approach.
> > 
> > Thoughts?
> 
> Yes, this should work, but now I worry I need to go audit all of perf
> and sched for this :/

I can't find any other sites just now, so let me queue this.

I also had a brief look if you used any other locks under rnp->lock, but
aside from the printk and sched things it seems clean.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/