Re: [PATCH] livepatch: Cleanup page permission changes

From: Josh Poimboeuf
Date: Wed Nov 04 2015 - 11:13:54 EST


On Wed, Nov 04, 2015 at 10:10:06AM -0600, Josh Poimboeuf wrote:
> On Wed, Nov 04, 2015 at 10:18:29AM +0100, Jiri Kosina wrote:
> > On Tue, 3 Nov 2015, Josh Poimboeuf wrote:
> >
> > > It's probably a good idea to keep the patches bisectable, so I made this
> > > a separate patch which applies on top of the first one.
> > >
> > > (Note that it completely removes all the code from the first patch, so
> > > there's no need for a v2 of the first patch which would have had
> > > Miroslav's suggested style changes.)
> >
> > I like this patch and it's something I'd like to queue for 4.4, but given
> > the fact that the original "[PATCH] x86/livepatch: Fix crash with
> > !CONFIG_DEBUG_SET_MODULE_RONX" wasn't queued in any tree yet, I don't
> > think that sending it as a followup patch is of any use.
> >
> > So if you agree, I'll just fold the two patches together and use the
> > changelog below, and queue it for merge with Linus.
>
> I kept them separate because the first patch is a low risk bug fix, and
> the second is a slightly higher risk cleanup.
>
> Would it make sense to put the first one into 4.4 and queue the second
> one for 4.5?

BTW, the second one is still pretty low risk, so it's fine with me if
you decide you still want to squash them for 4.4.

--
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/