Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

From: Linus Walleij
Date: Thu Nov 05 2015 - 08:40:18 EST

On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:

> The dependency "depends on RESET_CONTROLLER" is already met.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

NACK, this pin controller needs that as dependency, I don't worry
that it's overspecified.

They both do this:
#include <linux/reset.h>

And the object should specify its dependencies, not rely on them
being implicitly available.

The dep is there for human readers too, not just machines. And to
them, this is helpful information.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at