Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

[Andy Shevchenko]

On Thu, Nov 5, 2015 at 8:31 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Date: Thu, 5 Nov 2015 20:13:21 +0200
>
>> What about
>>
>> if (!addr)
>>  return -ENODATA;
>
> I totally disagree.  of_get_phy_mode() and other similar attribute
> probing mechanisms use -ENODEV.

Okay, then just
if (!addr)
 return -ENODEV;

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/