Re: [PATCH 4/4] dm verity: ignore zero blocks
From: kbuild test robot
Date: Thu Nov 05 2015 - 17:14:20 EST
Hi Sami,
[auto build test WARNING on: dm/for-next]
[also build test WARNING on: v4.3 next-20151105]
url: https://github.com/0day-ci/linux/commits/Sami-Tolvanen/dm-verity-clean-up-duplicate-hashing-code/20151105-124458
base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
config: s390-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=s390
All warnings (new ones prefixed by >>):
drivers/md/dm-verity.c: In function 'verity_alloc_zero_digest':
>> drivers/md/dm-verity.c:1226:1: warning: 'verity_alloc_zero_digest' uses dynamic stack allocation
}
^
drivers/md/dm-verity.c: In function 'verity_fec_decode_rsb':
drivers/md/dm-verity.c:846:1: warning: 'verity_fec_decode_rsb' uses dynamic stack allocation
}
^
vim +/verity_alloc_zero_digest +1226 drivers/md/dm-verity.c
1210
1211 v->zero_digest = kmalloc(v->digest_size, GFP_KERNEL);
1212
1213 if (!v->zero_digest)
1214 return -ENOMEM;
1215
1216 zero_data = kzalloc(1 << v->data_dev_block_bits, GFP_KERNEL);
1217
1218 if (!zero_data)
1219 return -ENOMEM; /* verity_dtr will free zero_digest */
1220
1221 r = verity_hash(v, (struct shash_desc *)desc, zero_data,
1222 1 << v->data_dev_block_bits, v->zero_digest);
1223
1224 kfree(zero_data);
1225 return r;
> 1226 }
1227
1228 static int verity_parse_opt_args(struct dm_arg_set *as, struct dm_verity *v,
1229 const char *opt_string)
1230 {
1231 int r;
1232 unsigned long long num_ll;
1233 unsigned char num_c;
1234 char dummy;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data