[PATCH] powerpc: platform: 85xx: mpc85xx ADS: remove pci exclude

From: Daniel Walker
Date: Thu Nov 05 2015 - 19:31:27 EST

This code was reworked in commit,


This change removed the fsl_add_bridge() which originally was above
the addition of the pci_exclude_device function. I think the assumption was that
the pci_exclude_device would prevent changes to the bridge PCI config after
it's been added. It seems it wasn't fully tested on MPC85xx ADS because
if you move the fsl_add_bridge() the pci_exclude_device is set in the machine
description then you can never update the PCI Config since the exclude
prevents it. This disrupts things like DMA.

This issue was extensively debugged by David Beazley.

Cc: xe-kernel@xxxxxxxxxxxxxxxxxx
Cc: dbeazley@xxxxxxxxx
Cc: dwalker@xxxxxxxxxx
Signed-off-by: Daniel Walker <danielwa@xxxxxxxxx>
arch/powerpc/platforms/85xx/mpc85xx_ads.c | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ads.c b/arch/powerpc/platforms/85xx/mpc85xx_ads.c
index 7d12a19..de72a5f 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_ads.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_ads.c
@@ -36,17 +36,6 @@

#include "mpc85xx.h"

-#ifdef CONFIG_PCI
-static int mpc85xx_exclude_device(struct pci_controller *hose,
- u_char bus, u_char devfn)
- if (bus == 0 && PCI_SLOT(devfn) == 0)
- else
-#endif /* CONFIG_PCI */
static void __init mpc85xx_ads_pic_init(void)
struct mpic *mpic = mpic_alloc(NULL, 0, MPIC_BIG_ENDIAN,
@@ -145,10 +134,6 @@ static void __init mpc85xx_ads_setup_arch(void)

-#ifdef CONFIG_PCI
- ppc_md.pci_exclude_device = mpc85xx_exclude_device;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/