Re: [PATCH 04/10] pwm: core: use bitops

From: Olliver Schinagl
Date: Fri Nov 06 2015 - 09:49:33 EST

Hey Thierry,

but why have the bit macro at all then :)

But that choice I guess I leave to you, as it's your section, I know some submaintainers prefer it and want it to be used, so I guess it's something in general kernel wide that should be desided on, BIT() macro preferred or not.


On 06-11-15 15:46, Thierry Reding wrote:
On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote:
From: Olliver Schinagl <oliver@xxxxxxxxxxx>

The pwm header defines bits manually while there is a nice bitops.h with
a BIT() macro. Use the BIT() macro to set bits in pwm.h

Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
include/linux/pwm.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
I don't think this is a useful change. The BIT() macro needs the same
number of characters to type at the expense of requiring an additional


Met vriendelijke groeten, Kind regards, ääåçéå

Olliver Schinagl
Software Engineer
Research & Development
Ultimaker B.V.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at