Re: [PATCH 3/3] Staging: lustre: tracefile: Remove function prototype

From: Dilger, Andreas
Date: Sat Nov 07 2015 - 02:32:58 EST

On 2015/11/06, 10:19, "Shivani Bhardwaj" <shivanib134@xxxxxxxxx> wrote:

>Remove the prototype of function cfs_trace_free_string_buffer() as it is
>no longer needed.

These patches would be a lot more useful if the summary contained the name
of the function being removed, rather than "remove function prototype" and
variations of that. Something like:

staging: lustre: remove cfs_trace_free_string_buffer prototype
staging: lustre: remove ldlm_pool_set_limit wrapper
staging: lustre: remove ldlm_pool_get_limit wrapper

Not sure if that is grounds for rejection of this patch series (I'll leave
that up to Dan and Greg), but definitely something for future patches.

Cheers, Andreas

>Signed-off-by: Shivani Bhardwaj <shivanib134@xxxxxxxxx>
> drivers/staging/lustre/lustre/libcfs/tracefile.h | 1 -
> 1 file changed, 1 deletion(-)
>diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.h
>index 73d60e0..ba62005 100644
>--- a/drivers/staging/lustre/lustre/libcfs/tracefile.h
>+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.h
>@@ -70,7 +70,6 @@ int cfs_trace_copyin_string(char *knl_buffer, int
> int cfs_trace_copyout_string(char __user *usr_buffer, int usr_buffer_nob,
> const char *knl_str, char *append);
> int cfs_trace_allocate_string_buffer(char **str, int nob);
>-void cfs_trace_free_string_buffer(char *str, int nob);
> int cfs_trace_dump_debug_buffer_usrstr(void __user *usr_str, int
> int cfs_trace_daemon_command(char *str);
> int cfs_trace_daemon_command_usrstr(void __user *usr_str, int

Cheers, Andreas
Andreas Dilger

Lustre Software Architect
Intel High Performance Data Division

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at