Re: [RESEND RFC PATCH 00/32] separate operations from flags in the bio/request structs

From: Christoph Hellwig
Date: Sat Nov 07 2015 - 05:11:40 EST


On Wed, Nov 04, 2015 at 04:07:57PM -0600, mchristi@xxxxxxxxxx wrote:
> Known issues:
> - REQ_FLUSH is still a flag, but should probably be a operation.
> For lower level drivers like SCSI where we only get a flush, it makes
> more sense to be a operation. However, upper layers like filesystems
> can send down flushes with writes, so it is more of a flag for them.
> I am still working on this.

Actually it should be both. REQ_OP_FLUSH for a real flush operation,
and a REQ_PREFLUSH bio flag that the request layer will sequence into
an actual write an a flush operation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/