Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables
From: Alexandre Courbot
Date: Mon Nov 09 2015 - 01:10:23 EST
On Mon, Nov 9, 2015 at 10:28 AM, William Breathitt Gray
> On 11/08/2015 06:53 PM, Alexandre Courbot wrote:
>> Apart from that this patch seems harmless and the repositioning of
>> some constant declarations is also welcome.
> I'll create a separate patch to reposition the constant declarations. Where in
> particular do you believe would be best for them to be positioned?
I was talking about what you did here:
@@ -109,24 +109,23 @@ static int __init idio_16_probe(struct
struct device *dev = &pdev->dev;
struct idio_16_gpio *idio16gpio;
+ const unsigned base = idio_16_base;
+ const unsigned extent = 8;
+ const char *const name = dev_name(dev);
- const unsigned BASE = idio_16_base;
- const unsigned EXTENT = 8;
- const char *const NAME = dev_name(dev);
So this is already done - sorry for not having been clear.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/