Re: [PATCH] mmc: MMC_GOLDFISH should depend on HAS_DMA

From: Ulf Hansson
Date: Mon Nov 09 2015 - 08:28:14 EST


On 9 November 2015 at 10:36, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> If NO_DMA=y:
>
> ERROR: dma_unmap_sg [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_alloc_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_map_sg [drivers/mmc/host/android-goldfish.ko] undefined!
> ERROR: dma_free_coherent [drivers/mmc/host/android-goldfish.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks, applied for fixes!

Kind regards
Uffe

> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index af71de5fda3b48c9..1dee533634c986d7 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -473,6 +473,7 @@ config MMC_DAVINCI
>
> config MMC_GOLDFISH
> tristate "goldfish qemu Multimedia Card Interface support"
> + depends on HAS_DMA
> depends on GOLDFISH || COMPILE_TEST
> help
> This selects the Goldfish Multimedia card Interface emulation
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/