Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed

From: Linus Walleij
Date: Mon Nov 09 2015 - 08:28:15 EST

On Fri, Nov 6, 2015 at 12:37 AM, Andrew Duggan <aduggan@xxxxxxxxxxxxx> wrote:

> From: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> Host Notify does not work with neither IRQ nor polling. Allow a RMI4 driver
> to request or not polling depending on the attn_gpio.
> When neither the internal IRQ or polling systems are used, the
> transport driver can call rmi_process_interrupt_requests() to
> trigger a process of the alert.
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> Tested-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>

> + } else if (pdata->attn_gpio == RMI_POLLING) {
> +#define RMI_POLLING -1

Aeuck ... this thing should be rewritten to use GPIO descriptors
instead of this old number-based stuff.

I'll go in and see if I can take a stab at it.

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at