Re: [PATCH v4 0/6] virtio core DMA API conversion
From: Michael S. Tsirkin
Date: Mon Nov 09 2015 - 08:28:11 EST
On Thu, Oct 29, 2015 at 06:09:45PM -0700, Andy Lutomirski wrote:
> This switches virtio to use the DMA API unconditionally. I'm sure
> it breaks things, but it seems to work on x86 using virtio-pci, with
> and without Xen, and using both the modern 1.0 variant and the
> legacy variant.
> This appears to work on native and Xen x86_64 using both modern and
> legacy virtio-pci. It also appears to work on arm and arm64.
> It definitely won't work as-is on s390x, and I haven't been able to
> test Christian's patches because I can't get virtio-ccw to work in
> QEMU at all. I don't know what I'm doing wrong.
> It doesn't work on ppc64. Ben, consider yourself pinged to send me
> a patch :)
> It doesn't work on sparc64. I didn't realize at Kernel Summit that
> sparc64 has the same problem as ppc64.
> DaveM, for background, we're trying to fix virtio to use the DMA
> API. That will require that every platform that uses virtio
> supplies valid DMA operations on devices that use virtio_ring.
> Unfortunately, QEMU historically ignores the IOMMU on virtio
> On x86, this isn't really a problem. x86 has a nice way for the
> platform to describe which devices are behind an IOMMU, and QEMU
> will be adjusted accordingly. The only thing that will break is a
> recently-added experimental mode.
Well that's not exactly true. I think we would like to make
it possible to put virtio devices behind an IOMMU on x86,
but if this means existing guests break, then many people won't be able
to use this option: having to find out which kernel version your guest
is running is a significant burden.
So on the host side, we need to detect guests that
don't program the IOMMU and make QEMU ignore it.
I think we need to figure out a way to do this
before we commit to the guest change.
Additionally, IOMMU overhead is very high when running within the VM.
So for uses such as VFIO, we'd like a way to make something like
iommu-pt the default.
> Ben's plan for powerpc is to add a quirk for existing virtio-pci
> devices and to eventually update the devicetree stuff to allow QEMU
> to tell the guest which devices use the IOMMU.
> AFAICT sparc has a similar problem to powerpc. DaveM, can you come
> up with a straightforward way to get sparc's DMA API to work
> correctly for virtio-pci devices?
> NB: Sadly, the platforms I've successfully tested on don't include any
> big-endian platforms, so there could still be lurking endian problems.
> Changes from v3:
> - More big-endian fixes.
> - Added better virtio-ring APIs that handle allocation and use them in
> virtio-mmio and virtio-pci.
> - Switch to Michael's virtio-net patch.
> Changes from v2:
> - Fix vring_mapping_error incorrect argument
> Changes from v1:
> - Fix an endian conversion error causing a BUG to hit.
> - Fix a DMA ordering issue (swiotlb=force works now).
> - Minor cleanups.
> Andy Lutomirski (5):
> virtio_ring: Support DMA APIs
> virtio_pci: Use the DMA API
> virtio: Add improved queue allocation API
> virtio_mmio: Use the DMA API
> virtio_pci: Use the DMA API
> Michael S. Tsirkin (1):
> virtio-net: Stop doing DMA from the stack
> drivers/net/virtio_net.c | 34 ++--
> drivers/virtio/Kconfig | 2 +-
> drivers/virtio/virtio_mmio.c | 67 ++-----
> drivers/virtio/virtio_pci_common.h | 6 -
> drivers/virtio/virtio_pci_legacy.c | 42 ++---
> drivers/virtio/virtio_pci_modern.c | 61 ++-----
> drivers/virtio/virtio_ring.c | 348 ++++++++++++++++++++++++++++++-------
> include/linux/virtio.h | 23 ++-
> include/linux/virtio_ring.h | 35 ++++
> tools/virtio/linux/dma-mapping.h | 17 ++
> 10 files changed, 426 insertions(+), 209 deletions(-)
> create mode 100644 tools/virtio/linux/dma-mapping.h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/