Re: [PATCH 22/26] Input: synaptics-rmi4 - Add F30 support

From: Linus Walleij
Date: Mon Nov 09 2015 - 08:32:20 EST

On Fri, Nov 6, 2015 at 12:42 AM, Andrew Duggan <aduggan@xxxxxxxxxxxxx> wrote:

> From: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> RMI4 Function 0x30 provides support for GPIOs, LEDs and mechanical
> buttons. In particular, the mechanical button support is used in
> an increasing number of touchpads.
> [BT] cured the code to rely only on the unified input node created
> by rmi_driver.
> Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> Signed-off-by: Allie Xiong <axiong@xxxxxxxxxxxxx>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>

I see this function driver is not yet adding any gpio_chip or
LEDs class devices, which is fine, we can add that later when
we have something to test. Or is iit using that LED feature
in the input layer that corresponds to caps lock etc?

I don't quite get it I guess :/

But I guess it should also be squashed into the original F30 driver.

Linus Waleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at