Re: [PATCH 0/2] selftests/mlock2: Build warning fixes on Debian/m68k 4.0

[Eric B Munson]

On Mon, 09 Nov 2015, Eric B Munson wrote:

> On Mon, 09 Nov 2015, Geert Uytterhoeven wrote:
> 
> > 	Hi,
> > 
> > The following 2 patches are needed to fix build warnings on Debian/m68k
> > 4.0.
> > 
> > However, after wiring up the mlock2 syscall, the test fails with:
> > 
> > # ./mlock2-tests
> > fread kpageflags: Success
> > # 
> > 
> > as the fread() call returns 0, not 1.
> 
> This would fail is the index into the kpageflags file is not being
> calculated properly.  This tests works on x86_64 (I am in the process of
> testing x86 incase this is a 32bit issue).  I am fairly sure that I
> tested it on x86, but it has been a while.

I can confirm that this test works on x86 as well as x86_64.
Unfortunately, I do not have access to m68k hardware to help debug this.

> 
> > 
> > The original commit description for the test said "Note that the limit
> > test needs to be run a normal user.". But running it as a non-root user
> > also fails:
> 
> The original commit says that the on-fault-limit test needs to be run as
> a regular user becuase it relies on enforcing memory limits.
> mlock2-tests has to be run as root to get access to the various files
> under /proc it needs to verify things are working.
> 
> > 
> > $ ./mlock2-tests 
> > fopen kpageflags: Permission denied
> > $ ls -l /proc/kpageflags 
> > -r-------- 1 root root 0 Nov  9 11:05 /proc/kpageflags
> > $
> > 
> > What am I missing?
> > 
> > Thanks!
> > 
> > Geert Uytterhoeven (2):
> >   selftests/mlock2: Add missing #define _GNU_SOURCE
> >   selftests/mlock2: Add ULL prefix to 64-bit constants
> > 
> >  tools/testing/selftests/vm/mlock2-tests.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > -- 
> > 1.9.1
> > 
> > Gr{oetje,eeting}s,
> > 
> > 						Geert
> > 
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> > 
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> > 							    -- Linus Torvalds

Attachment: signature.asc
Description: Digital signature