RE: [PATCH] comedi: comedi_parport: Fix coding style - use BIT macro

[Hartley Sweeten]

On Monday, November 09, 2015 8:17 AM, Ranjith wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith <ranjithece24@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/comedi_parport.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/comedi_parport.c b/drivers/staging/comedi/drivers/comedi_parport.c
> index 15a4093..1bf8ddc 100644
> --- a/drivers/staging/comedi/drivers/comedi_parport.c
> +++ b/drivers/staging/comedi/drivers/comedi_parport.c
> @@ -75,8 +75,8 @@
>  #define PARPORT_DATA_REG	0x00
>  #define PARPORT_STATUS_REG	0x01
>  #define PARPORT_CTRL_REG	0x02
> -#define PARPORT_CTRL_IRQ_ENA	(1 << 4)
> -#define PARPORT_CTRL_BIDIR_ENA	(1 << 5)
> +#define PARPORT_CTRL_IRQ_ENA	BIT(4)
> +#define PARPORT_CTRL_BIDIR_ENA	BIT(5)
>  
>  static int parport_data_reg_insn_bits(struct comedi_device *dev,
>  				      struct comedi_subdevice *s,

Hello,

No problems with the patch but your sign-off needs to include your
full legal name.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/